Merged
Conversation
added 6 commits
September 15, 2016 20:52
… sub-tasks (BOA unfork)
…low SSH tunneling for remote SQL access (BOA unfork)
…stmaster install (BOA unfork)
…migrate (BOA unfork)
…rt task (BOA unfork)
…ra sub-tasks and fixes (BOA unfork)
helmo
force-pushed
the
feature/boa-unfork
branch
from
76e15e7 to
a8d8389
Compare
jonpugh
reviewed
Oct 14, 2016
platform/migrate.provision.inc
Outdated
| if (!is_null(d($platform)->name) && (d($platform)->name == d()->platform->name)) { | ||
| drush_set_option('rename_only', TRUE); | ||
| foreach ($new_aliases as $alias) { | ||
| drush_log(dt("DEBUG RENAME new_aliases is @this", array('@this' => $alias))); |
Member
|
Should add tests before we call this one done:
|
Member
Author
|
@jonpugh can you create a new issue to add these extra tests? |
Member
Author
|
for reference @jonpugh already started a PR for a clone test in aegir-project/tests#11 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
various issues